Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display some actions after a form is submitted #18608

Merged

Conversation

AdrienClairembault
Copy link
Contributor

Checklist before requesting a review

  • I have performed a self-review of my code.

Description

Add two possible actions after a form is successfully submitted:

  • Go back to service catalog
  • See my tickets

An other alternative would be to replace "See my tickets" by a direct link to the created ticket (and remove the success toast that currently serve that purpose).
We would have to think about the cases where multiple tickets might be created tho, in this case maybe a link to a search request that returns all the newly created ticket (id=x or id=y or ...) ?

What do you think @orthagh ?

Screenshots (if appropriate):

image

@AdrienClairembault
Copy link
Contributor Author

AdrienClairembault commented Jan 6, 2025

TODO (discussed with @orthagh):

  • "Go back to service catalog" -> "Go home" with icon
  • "See my tickets" -> Add icon and primary style

@AdrienClairembault
Copy link
Contributor Author

New version:

image

@orthagh
Copy link
Contributor

orthagh commented Jan 6, 2025

👍 I think it's ok and sufficient.

@AdrienClairembault AdrienClairembault marked this pull request as ready for review January 6, 2025 10:30
@trasher
Copy link
Contributor

trasher commented Jan 7, 2025

Please rebase to solve conflict

@cedric-anne cedric-anne merged commit 6ae48bc into glpi-project:main Jan 7, 2025
9 checks passed
@cedric-anne cedric-anne added this to the 11.0.0 milestone Jan 7, 2025
@AdrienClairembault AdrienClairembault deleted the post-submit-form-actions branch January 7, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants