Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ticket rules are not correctly executed with MA #18612

Open
wants to merge 1 commit into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Dec 27, 2024

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35358
  • The data passed to the ticket rules engine when using bulk actions contains only the modified data, which prevents the correct execution of the rules.

Screenshots (if appropriate):

@MyvTsv MyvTsv self-assigned this Dec 27, 2024
@stonebuzz
Copy link
Contributor

@MyvTsv

This approach has already been attempted numerous times, but so far without success.

Attempting to restore all fields in the engine could trigger rules that are typically inactive, which poses a significant risk.
This is a major undertaking that is not planned in the short term, let alone in a bug-fix-oriented release.

Currently, the rules engine for tickets operates exclusively with updated fields, and this is an intentional decision.

@cconard96
Copy link
Contributor

I was under the impression that the current rules engine was expected to only work with the changes and not take into account existing data. The rules engine has no way to specify if you want the previous, change, or current value for a field.

#16885

I seem to remember a pull request that had a more extensive discussion about it years ago but I cannot find it now.

For the example they provided of a rule running when a category and entity match that assigns a technician group and changes the status, the entity and category have to be changed at the same time for the rule to work. Otherwise, the rule would trigger on every single update while the ticket is in the entity with that category and block the manual changing of the status or removal of the technician group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants