Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAS server status check #18734

Open
wants to merge 2 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

cedric-anne
Copy link
Member

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

The cas_host configuration corresponds to the CAS server hostname. It must be prefixed by https:// to build a valid URL.
It fixes #18346.

I cannot test against a real CAS server, so I cannot validate the rest of the status checking logic.

@cedric-anne cedric-anne self-assigned this Jan 15, 2025
@cedric-anne cedric-anne mentioned this pull request Jan 15, 2025
2 tasks
@trasher
Copy link
Contributor

trasher commented Jan 16, 2025

This seems OK, but we probably need to also prevent usage of protocol in configuration, no? Or at least check here if it's already present.

@cedric-anne cedric-anne marked this pull request as ready for review January 29, 2025 08:40
@cedric-anne
Copy link
Member Author

cedric-anne commented Jan 29, 2025

This seems OK, but we probably need to also prevent usage of protocol in configuration, no? Or at least check here if it's already present.

We may indeed improve this part, but I have no time to do it right now.

Right now, the status check will not work when the configuration is already done and is correct. The proposed changes focus on fixing that.

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot test.

@cedric-anne cedric-anne force-pushed the 10.0/fix-cas-status-check branch from 8064f9e to 22176f0 Compare January 29, 2025 11:34
@cedric-anne
Copy link
Member Author

In GLPI, the default cas_port value is 443 (the default HTTPS port). I added a commit to consider the presence of the :80 port in HTTP URLs and the :443 port in HTTPS URLs as safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants