Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Inventory): set default instantiation type #18746

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Fix(Inventory): set default instantiation type #18746

merged 6 commits into from
Jan 20, 2025

Conversation

stonebuzz
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !35886

Set default instantiation_type to NetworkPortEthernet when type is undefined and mac is set

Screenshots (if appropriate):

@stonebuzz stonebuzz force-pushed the fix_inventory_default_networkport_instantiation branch from 7e311e1 to a33683f Compare January 17, 2025 09:16
@stonebuzz stonebuzz marked this pull request as draft January 17, 2025 09:16
@stonebuzz stonebuzz self-assigned this Jan 17, 2025
@stonebuzz stonebuzz added this to the 10.0.18 milestone Jan 17, 2025
@stonebuzz
Copy link
Contributor Author

Waiting for the results of the current unit tests

@trasher
Copy link
Contributor

trasher commented Jan 17, 2025

Please add a test case ;)

@stonebuzz
Copy link
Contributor Author

stonebuzz commented Jan 17, 2025 •
edited
Loading

image

@stonebuzz stonebuzz marked this pull request as ready for review January 17, 2025 13:26
@stonebuzz @trasher
remove useless data
050d8da 
Co-authored-by: Johan Cwiklinski <trasher@x-tnd.be>
@cedric-anne cedric-anne merged commit f18e27b into glpi-project:10.0/bugfixes Jan 20, 2025
6 checks passed
@g-bougard g-bougard mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

@cedric-anne cedric-anne cedric-anne approved these changes

@AdrienClairembault AdrienClairembault Awaiting requested review from AdrienClairembault

Assignees

@stonebuzz stonebuzz

Labels
bug inventory
Projects
None yet
Milestone
10.0.18
Development

Successfully merging this pull request may close these issues.
3 participants
@stonebuzz @trasher @cedric-anne