Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape in titles #2795

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Escape in titles #2795

merged 2 commits into from
Sep 20, 2017

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Sep 20, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes

@trasher trasher requested a review from orthagh September 20, 2017 13:29
orthagh
orthagh reviewed Sep 20, 2017
View reviewed changes
inc/levelagreement.class.php Outdated
@@ -298,7 +298,7 @@ function showForTicket(Ticket $ticket, $type, $tt, $canupdate) {
function delete_date$type$rand(e) {
e.preventDefault();

if (nativeConfirm('".__('Also delete date ?')."')) {
if (window.confirm('".__s('Also delete date ?')."')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep nativeConfirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... But why?

@trasher trasher merged commit 873caa1 into glpi-project:9.2/bugfixes Sep 20, 2017
@trasher trasher deleted the escape-in-titles branch September 20, 2017 14:44
@trasher trasher mentioned this pull request Sep 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trasher @orthagh