Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent kb items duplicates in list; fixes #2899 #2944

Closed
wants to merge 3 commits into from
Closed

Prevent kb items duplicates in list; fixes #2899 #2944

wants to merge 3 commits into from

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Oct 11, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2899

@trasher trasher requested a review from orthagh October 11, 2017 07:16
orthagh
orthagh requested changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@orthagh orthagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to prevent future issues with other database engine
we should do full group by in queries.

So in the request call, we should have also $id_field In SELECT part (and set all non aggregate fields in the GROUPBY part)

@trasher
Copy link
Contributor Author

trasher commented Oct 11, 2017

You are right; but rather than play with GROUPBY issues; I've prefered to use DISTINCT.

DBmysqlIterator was not able to do that; so I've added the feature (+ tests)

@trasher trasher closed this Oct 13, 2017
@trasher trasher deleted the fix-2899 branch October 13, 2017 10:20
@snyk-bot snyk-bot mentioned this pull request Jun 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh requested changes

Assignees
No one assigned
Labels
need_cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trasher @orthagh