Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticket status in navigation header #2965

Closed
wants to merge 3 commits into from

Conversation

Drimmwald
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes

Issues #2964

@trasher
Copy link
Contributor

trasher commented Oct 13, 2017

Hello,

Thanks for the PR, I got some remarks. First, CS checks are failing (not very important, but this needs to be fixed).

Second, copying the entire showNavigationHeader is probably not the way to go; we need to find something more generic I guess.

@trasher
Copy link
Contributor

trasher commented Oct 13, 2017

Maybe adding an option to existing method should does the trick (I've just took a very quick look)

@trasher
Copy link
Contributor

trasher commented Oct 16, 2017

Great; that sounds better :)

Just one more remark: maybe this new code should be run only if we're from a Ticket (or maybe from a CommonITILObject; I guess this should appply as well on Changes and Problems).

@Drimmwald
Copy link
Contributor Author

I think you are right. Now code working with Changes and Problems, but some styles of these statuses are absent. I will try fix in the near time.

@orthagh
Copy link
Contributor

orthagh commented Oct 27, 2017

Sorry to answer late on this submission, but this is not ok imo.
We have an existing iconography for ITIL status representation and the submitted colors didn't match at all.
image

This set may be outdated and subject to review but we need to do a spec on this (on spec wiki: https://github.com/glpi-project/spec/wiki).
And this change should aim next major version.

In parallel, we can try to transform theses images in full css.

@trasher
Copy link
Contributor

trasher commented Apr 6, 2018

Reworked; see #3820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants