Replace CR LF with a html BR tag for the software version comments #3040
Conversation
Now the notes will look good on the screen if it has a new line in it.
inc/softwareversion.class.php
Outdated
| @@ -329,8 +329,8 @@ static function showForSoftware(Software $soft) { | |||
| echo "<td class='right'>".Dropdown::getDropdownName('glpi_operatingsystems', | |||
| $data['operatingsystems_id']); | |||
| echo "</td>"; | |||
| echo "<td class='numeric'>$nb</td>"; | |||
| echo "<td>".$data['comment']."</td></tr>\n"; | |||
| echo "<td class='numeric'>$nb</td>"; | |||
There was a problem hiding this comment.
warning, you added some trailing spaces after the end of this line (tests fail because that)
There was a problem hiding this comment.
Apologies. First time I've done this on github.
Extra spaces removed.
inc/softwareversion.class.php
Outdated
| @@ -329,8 +329,8 @@ static function showForSoftware(Software $soft) { | |||
| echo "<td class='right'>".Dropdown::getDropdownName('glpi_operatingsystems', | |||
| $data['operatingsystems_id']); | |||
| echo "</td>"; | |||
| echo "<td class='numeric'>$nb</td>"; | |||
| echo "<td>".$data['comment']."</td></tr>\n"; | |||
| echo "<td class='numeric'>$nb</td>"; | |||
There was a problem hiding this comment.
Apologies. First time I've done this on github.
|
last thing, @vrdriver, could you post here (and on the original issue) a screeshot of the change ? |
|
Please note the new formatting of the notes for both of these images. Before and After. |
vrdriver
changed the title
|
Perfect. LGTM for merging |
|
Great. Well there's a first for me. A pull request and commit on github to an open source project. cheers. Keep up the good work with GLPI. 👍 I'll let you do the rest. ' |
tomolimo
changed the title
|
Please do not close until it's merged ;) Same for refering tickets :) |
…3040) Now the notes will look good on the screen if it has a new line in it.
Replace CR LN with a html br tag for the version comments.
Please update this template with something that matches your PR