Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pictures public faq #3065

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Fix pictures public faq #3065

merged 2 commits into from
Oct 27, 2017

Conversation

orthagh
Copy link
Contributor

@orthagh orthagh commented Oct 27, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2980

@orthagh orthagh requested a review from trasher October 27, 2017 09:35
trasher
trasher approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@trasher trasher merged commit 72e8ceb into glpi-project:9.2/bugfixes Oct 27, 2017
@ralporto
Copy link

ralporto commented Feb 8, 2018

Hello
This fix added a new bug. The profile images of users are missed now.

@orthagh
Copy link
Contributor Author

orthagh commented Feb 9, 2018

Hello @ralporto
Please open a new issue.
I don't think the bug you describe is linked to this pr.

@snyk-bot snyk-bot mentioned this pull request Sep 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trasher trasher trasher approved these changes

Assignees
No one assigned
Labels
need_cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orthagh @ralporto @trasher