Uneeded concat (on licence name) for licence inventory number and lic… #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence serial number + add a default case on the switch
Fix CS / Whitespace
|
Looks good to me; but I'm always unsure speaking of search engine... @orthagh, please take a look. |
trasher
pushed a commit
that referenced
this pull request
Nov 28, 2017
#3208) * Uneeded concat (on licence name) for licence inventory number and licence serial number + add a default case on the switch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove uneeded concat for Licence inventory number and licence serial number and comments.
It's usefull for column name, but not for column value.
Previous design
New design :