Feature/pdu #3300
Merged
Feature/pdu #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trasher
commented
Dec 14, 2017
trasher
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
trasher
force-pushed
the
feature/pdu
branch
2 times, most recently
from
2e413ea to
c58259b
Compare
trasher
force-pushed
the
feature/pdu
branch
2 times, most recently
from
a107999 to
590e00b
Compare
orthagh
reviewed
Dec 15, 2017
inc/pdu.class.php
Outdated
| return true; | ||
| } | ||
|
|
||
| /*function getSearchOptionsNew() { |
There was a problem hiding this comment.
Indeed, yes; I forget to do that part
| echo "<td><label for='comment'>".__('Comments')."</label></td>"; | ||
| echo "<td colspan='3' class='middle'>"; | ||
|
|
||
| echo "<textarea cols='45' rows='3' id='comment' name='comment' >". |
There was a problem hiding this comment.
not mandatory, but we have a function Html::textarea
There was a problem hiding this comment.
Just quickly tested... Seems that there are issues with labels (name is not part of the id, rand seems ignored, ...) :(
orthagh
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.