-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.91 associated items #424
Conversation
fix #283 |
There is conflict (sorry for delay), could you fix them ? Some comments incoming. |
} else { | ||
$rand = mt_rand(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefers this notation :
$rand = mt_rand();
if (isset($_POST["rand"])) {
$rand = $_POST["rand"];
}
Conflicts: inc/dropdown.class.php install/update_0901_091.php
I fixed all conflicts |
Some comments (maybe more incoming) :
|
The feature seems ok. |
Fix install
One problem, if you create a ticket from an asset (from ticket tab of a computer for example), an error triggers :
|
Ok i cleaned the remaining trailing spaces :) |
in install/update_0901_091.php, you have always some trailing tabs l383-432 |
Clean trailing spaces
I fixed the ticket add from assets, and cleaned trailing spaces |
Undefined index: id in /home/yllen/gitsvn/inc/item_ticket.class.php at line 238 |
I've added an Ajax mini-form to add/delete a list of items on ticket.
It's now possible to set multiple items with predefined values (ticket template)
It's also possible to set multiple items with the ticket rules
Migration added to convert templates with the new functionnality