Collector : can now specify where the requester's email is found #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'from' : current behavior 'reply-to' : use the email found in the 'reply-to' header
orthagh
reviewed
Sep 4, 2018
|
Same for the label. |
orthagh
reviewed
Sep 4, 2018
install/mysql/glpi-empty.sql
Outdated
| @@ -4292,6 +4292,7 @@ CREATE TABLE `glpi_mailcollectors` ( | |||
| `errors` int(11) NOT NULL DEFAULT '0', | |||
| `use_mail_date` tinyint(1) NOT NULL DEFAULT '0', | |||
| `date_creation` datetime DEFAULT NULL, | |||
| `caller_location` enum('from', 'reply-to') NOT NULL DEFAULT 'from', | |||
There was a problem hiding this comment.
Don't use enum, two possibility:
- integer with const in MailCollector class for values (prefered method)
- direct varchar
|
BTW, functional tests : OK |
AdrienClairembault
changed the title
orthagh
approved these changes
Sep 6, 2018
cedric-anne
approved these changes
Sep 6, 2018
trasher
reviewed
Sep 6, 2018
install/update_93_94.php
Outdated
| @@ -61,6 +61,12 @@ function update93to94() { | |||
| } | |||
| /** /Add default group for a user */ | |||
|
|
|||
| /** Add caller location on glpi_mailcollectors */ | |||
| if (!$DB->fieldExists('glpi_mailcollectors', 'requester_field')) { | |||
| $migration->addField("glpi_mailcollectors", "requester_field", "int(11) NOT NULL DEFAULT '0'"); | |||
There was a problem hiding this comment.
You should use "integer" automatic type instead of full declaration
trasher
approved these changes
Sep 6, 2018
AdrienClairembault
added a commit
to AdrienClairembault/glpi
that referenced
this pull request
May 14, 2020
AdrienClairembault
added a commit
to AdrienClairembault/glpi
that referenced
this pull request
May 14, 2020
AdrienClairembault
added a commit
to AdrienClairembault/glpi
that referenced
this pull request
May 14, 2020
AdrienClairembault
added a commit
to AdrienClairembault/glpi
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'from' : current behavior
'reply-to' : use the email found in the 'reply-to' header