Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cascading of AND/OR operator in dbiterator #5428

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Remove cascading of AND/OR operator in dbiterator #5428

merged 2 commits into from
Feb 25, 2019

Conversation

cedric-anne
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -

@cedric-anne cedric-anne self-assigned this Feb 20, 2019
@cedric-anne cedric-anne added this to the 9.4.1 milestone Feb 20, 2019
@cedric-anne cedric-anne mentioned this pull request Feb 20, 2019
Closed
trasher
trasher reviewed Feb 20, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@trasher
Copy link
Contributor

trasher commented Feb 20, 2019

OK for me, waiting tests to approve

@cedric-anne cedric-anne force-pushed the 9.4/remove-dbiterator-operator-cascading branch from 5dcabef to d0b49a4 Compare February 22, 2019 10:56
@cedric-anne
Copy link
Member Author

I searched for all /(['"]AND['"]|['"]OR['"])/i and I removed all AND operators that were useless (except for cases were code was not easy to read).
I do not see any case were we intentionnaly wanted a cascading OR, but a lot of cases where we had to put an  AND operator to prevent this cascading.

@cedric-anne cedric-anne mentioned this pull request Feb 24, 2019
Closed
@cedric-anne cedric-anne force-pushed the 9.4/remove-dbiterator-operator-cascading branch from d0b49a4 to 59a7414 Compare February 25, 2019 08:32
@trasher trasher merged commit 3083718 into glpi-project:9.4/bugfixes Feb 25, 2019
@cedric-anne cedric-anne deleted the 9.4/remove-dbiterator-operator-cascading branch February 25, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orthagh orthagh orthagh approved these changes

@trasher trasher trasher approved these changes

Assignees

@cedric-anne cedric-anne

Labels
None yet
Projects
None yet
Milestone
9.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cedric-anne @trasher @orthagh