Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To add pre_show, post_show for items and tabs #777

Merged
merged 1 commit into from
Jul 6, 2016
Merged

To add pre_show, post_show for items and tabs #777

merged 1 commit into from
Jul 6, 2016

Conversation

tomolimo
Copy link
Contributor

@tomolimo tomolimo commented Jul 1, 2016

Issue #685
Added pre_show_tab, post_show_tab
Added pre_show_item, post_show_item

Commit for example plugin will follow

Added pre_show_item, post_show_item
@tomolimo
Copy link
Contributor Author

tomolimo commented Jul 1, 2016

done in Example plugin: pluginsGLPI/example#6

@orthagh
Copy link
Contributor

orthagh commented Jul 5, 2016

Hello @tomolimo

Your PR in example plugin fail to merge, could you check ?
Could you also complete this page : https://github.com/pluginsGLPI/example/wiki/0.90.1-to-0.91

@tomolimo
Copy link
Contributor Author

tomolimo commented Jul 5, 2016

Your PR in example plugin fail to merge, could you check ?

Where? Could you point me to an error message or else?

@orthagh
Copy link
Contributor

orthagh commented Jul 5, 2016

pluginsGLPI/example#6

image

@tomolimo
Copy link
Contributor Author

tomolimo commented Jul 5, 2016

Yes I saw this but...:)
I'll check that and push the corrected files

@tomolimo
Copy link
Contributor Author

tomolimo commented Jul 5, 2016

I've merged and pushed the modifications into Example.
See: pluginsGLPI/example@1db4385

@orthagh
Copy link
Contributor

orthagh commented Jul 5, 2016

Ok great.

Think about the wiki also, thank you

@tomolimo
Copy link
Contributor Author

tomolimo commented Jul 5, 2016

on going :)

@tomolimo
Copy link
Contributor Author

tomolimo commented Jul 5, 2016

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants