Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticket rule action : add task template #8654

Closed
wants to merge 3 commits into from
Closed

Add ticket rule action : add task template #8654

wants to merge 3 commits into from

Conversation

ales-infotel
Copy link
Contributor

This is a new feature for ticket rules. It adds a new action for adding task templates.
I couldn't pass the tests because there was an error on the composer install with the master.
logs error :

@php -r "file_put_contents('.composer.hash', sha1_file('composer.lock'));"
patch -f -p1 -d vendor/tecnickcom/tcpdf/ < tools/tcpdf-php8-compat.patch || echo 'Error applying patch, deprecation warnings related to TCPDF lib may pollute logs'
(Stripping trailing CRs from patch; use --binary to disable.)
patching file include/tcpdf_fonts.php
Hunk #1 FAILED at 1995.
Hunk #2 FAILED at 2021.
Hunk #3 FAILED at 2037.
Hunk #4 FAILED at 2057.
Hunk #5 FAILED at 2074.
Hunk #6 FAILED at 2090.
6 out of 6 hunks FAILED -- saving rejects to file include/tcpdf_fonts.php.rej

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? ?

@cedric-anne
Copy link
Member

Hi,

As this is a new feature, I switched target branch to master. Please rebase your pull request.

Regards

@trasher
Copy link
Contributor

trasher commented Feb 11, 2021

This is a new feature for ticket rules. It adds a new action for adding task templates.
I couldn't pass the tests because there was an error on the composer install with the master.

This is just because you already did a "composer install", and patch already have been applied.
This does not prevent GLPI nor its tests from running.

@cedric-anne cedric-anne changed the base branch from 9.5/bugfixes to master February 11, 2021 09:03
@ales-infotel ales-infotel changed the base branch from master to 9.5/bugfixes February 11, 2021 09:05
@ales-infotel ales-infotel changed the base branch from 9.5/bugfixes to master February 11, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants