Support KHR_texture_basisu extension #392
Open
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testmerge # Conflicts: # gltf-json/src/extensions/texture.rs
aW4KeNiNG
force-pushed
the
KHR_texture_basisu
branch
from
7212c0d to
21208b2
Compare
|
@alteous Hi, sorry to bother you, is there any way we could get this merged please? I am happy to adopt it if @aW4KeNiNG is not available and make any changes to the PR. I am trying to add support for GLTFs with compressed textures to Bevy. |
# Conflicts: # gltf-json/src/extensions/texture.rs # gltf-json/src/image.rs # gltf-json/src/texture.rs # src/texture.rs
|
I have rebased the changes here: alteous@70312ff Do these look good to you? I can update the PR if so and get them merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for the KHR_texture_basisu extension.
Extension information: https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_texture_basisu/README.md