Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PySide6 test envs to CI #34

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Aug 23, 2022

Description

Configurations for 3 pyside63 envs on linux, macos and windows.
Closes #30

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #34 (745a2f3) into master (b6ef9b4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files          16       16           
  Lines        2098     2098           
=======================================
  Hits         1978     1978           
  Misses        120      120           
Impacted Files Coverage Δ
echo/qt/connect.py 73.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dhomeier dhomeier changed the title Add PySide2 6.3 test envs to CI Add PySide6 test envs to CI Aug 23, 2022
@dhomeier dhomeier requested a review from astrofrog August 23, 2022 22:41
@dhomeier dhomeier marked this pull request as ready for review August 23, 2022 22:42
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@astrofrog astrofrog merged commit 1b1291e into glue-viz:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against PyQt6/PySide6
2 participants