feat: add table viewer based in ipyvuetify #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maartenbreddels - can you rebase now that #115 is merged? (I think it will fix the CI issues) |
maartenbreddels
force-pushed
the
feat_table_viewer
branch
from
abd2b0c
to
e002a1d
Compare
|
failures now are due to ipyvuetify 1.0, which models vuetify 2. I think we should fix that first in master and rebase again. |
maartenbreddels
force-pushed
the
feat_table_viewer
branch
from
e002a1d
to
c58dd9e
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 92.2% 92.21% +<.01%
==========================================
Files 80 83 +3
Lines 3234 3404 +170
==========================================
+ Hits 2982 3139 +157
- Misses 252 265 +13
Continue to review full report at Codecov.
|
|
@maartenbreddels - can you rebase now that #132 is merged? |
maartenbreddels
force-pushed
the
feat_table_viewer
branch
from
c58dd9e
to
9109735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although ipysheet was discussed as a table viewer, I don't think it is the proper widget to do this. It does not enforce a common datatype per column, since it models a spreadsheet, not columnar data. Also, it will be limited in the amount of data it can handle (e.g. don't expect to view the Gaia dataset with it).
Experimenting with vuetify's data table, I've been able to put together a table viewer that will do kernel side pagination, is consistent with the ipyvuetify look, and more easy to customize to our needs.
Note that when we move to vuetify 2.0+, the data table also has a dense layout
Example usage (rebased on the vuetify layout branch #115)
Example using ~1 billion rows (Gaia data):
