Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate draws in FRBMark #249

Merged
merged 5 commits into from
Aug 10, 2021

Conversation

astrofrog
Copy link
Member

This does some small optimizations with FRBMark updating to avoid updating too many times when adding a layer

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #249 (87ec10a) into master (b1a514a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   89.17%   89.17%   -0.01%     
==========================================
  Files          82       82              
  Lines        4038     4037       -1     
==========================================
- Hits         3601     3600       -1     
  Misses        437      437              
Impacted Files Coverage Δ
glue_jupyter/bqplot/image/frb_mark.py 63.41% <ø> (-0.88%) ⬇️
glue_jupyter/bqplot/image/layer_artist.py 88.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a514a...87ec10a. Read the comment docs.

@astrofrog astrofrog merged commit 296f0f2 into glue-viz:master Aug 10, 2021
@pllim
Copy link
Contributor

pllim commented Aug 10, 2021

This might have caused a problem with second image not showing up in Layers data drop-down menu as @rosteen reported in spacetelescope/jdaviz#765 (comment)

@pllim
Copy link
Contributor

pllim commented Aug 10, 2021

I folded a possible fix into #244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants