Fix updating of layers list #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n layer artists and not layer state we should be listening to the layer artist event.
2 tasks
1 task
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 89.17% 89.15% -0.03%
==========================================
Files 82 82
Lines 4037 4037
==========================================
- Hits 3600 3599 -1
- Misses 437 438 +1
Continue to review full report at Codecov.
|
|
Turns out this fix is incomplete. It broke the "eye" icon from updating on blink. See #265 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #250 - we weren't connecting the callback in the right place, and were ending up in a state where the layers state had been updated but not layer artists. This uses private API but in glue-core so this is fine (though we should probably expose this publicly anyway).