Initial clean-up to produce glue-qt #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
astrofrog
force-pushed
the
glue-qt-initial
branch
2 times, most recently
from
744240b to
28f27ef
Compare
astrofrog
force-pushed
the
glue-qt-initial
branch
from
54836a1 to
f23b24a
Compare
13 tasks
|
I think this is ready so I'll go ahead and merge! |
dhomeier
reviewed
Aug 16, 2023
|
|
||
| try: | ||
| from glue.core import BaseData, Data | ||
| from glue.core.cli_parsers import parse_data, parse_links |
There was a problem hiding this comment.
Should this be
from glue.core.parsers import parse_data, parse_linksor will the path be changed in glue-core yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of glue-viz/glue#2430
This transitions the code in this repository to just be the glue-qt package. Not at all complete for now, just experimental.
Known TODOs: