Merge pull request #896 from astrofrog/skip-vector-columns

Gracefully skip vector columns from FITS files

CHANGES.md

@@ -19,6 +19,8 @@ v0.7.1 (2016-03-29)
 * Fixed a bug that caused an abort trap if the filename specified on the
   command line did not exist. [#903]
 
+* Gracefully skip vector columnns when reading in FITS files. [#896]
+
 v0.7 (2016-03-10)
 -----------------
 

glue/core/data_factories/fits.py

@@ -116,6 +116,9 @@ def new_data():
                 groups[hdu_name] = data
                 for column_name in table.columns:
                     column = table[column_name]
+                    if column.ndim != 1:
+                        warnings.warn("Dropping column '{0}' since it is not 1-dimensional".format(column_name))
+                        continue
                     component = Component(column, units=column.unit)
                     data.add_component(component=component,
                                        label=column_name)

glue/core/data_factories/tests/test_fits.py

@@ -1,6 +1,7 @@
 from __future__ import absolute_import, division, print_function
 
 import os
+import warnings
 from copy import deepcopy
 from collections import namedtuple
 
@@ -189,3 +190,12 @@ def test_fits_compressed():
     d = df.load_data(os.path.join(DATA, 'compressed_image.fits'),
                      factory=df.fits_reader)
     assert d.ndim == 2
+
+
+@requires_astropy
+def test_fits_vector():
+    # Regression test for bug that caused tables with vector columns to not load
+    with warnings.catch_warnings(record=True) as w:
+        df.load_data(os.path.join(DATA, 'events.fits'), factory=df.fits_reader)
+    assert len(w) == 1
+    assert str(w[0].message) == "Dropping column 'status' since it is not 1-dimensional"