Merge pull request #1471 from astrofrog/fix-update-viewers-numerical

Fix updating of viewers when numerical values are changed

CHANGES.md

@@ -9,6 +9,9 @@ v0.12.2 (unreleased)
 v0.12.1 (2017-10-30)
 --------------------
 
+* Fix a bug that caused the 1D and 2D viewers to not update correctly
+  when the numerical values in data were changed. [#1471]
+
 * Fix a bug that caused glue to crash when adding components to a dataset
   after closing a viewer that had that data. [#1460, #1464]
 

glue/viewers/common/qt/data_viewer_with_state.py

@@ -191,7 +191,7 @@ def register_to_hub(self, hub):
                       filter=self._has_data_or_subset)
 
         hub.subscribe(self, msg.NumericalDataChangedMessage,
-                      handler=self._update_subset,
+                      handler=self._update_data,
                       filter=self._has_data_or_subset)
 
         hub.subscribe(self, msg.DataCollectionDeleteMessage,

glue/viewers/matplotlib/qt/tests/test_data_viewer.py

@@ -525,3 +525,15 @@ def test_apply_roi_undo(self):
 
         assert self.data.subsets[0].subset_state.lo == lo2
         assert self.data.subsets[0].subset_state.hi == hi2
+
+    def test_numerical_data_changed(self):
+        self.init_draw_count()
+        self.init_subset()
+        assert self.draw_count == 0
+        self.viewer.add_data(self.data)
+        assert self.draw_count == 1
+        data = Data()
+        for cid in self.data.visible_components:
+            data.add_component(self.data[cid] * 2, cid.label)
+        self.data.update_values_from_data(data)
+        assert self.draw_count == 2