Performance improvements for selection #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the bounding box of the polygon
…xel coordinates, since we can then simply broadcast the selection.
|
This also fixes #959 |
|
I'm marking this as 0.8.2 since it's 'just' a performance improvement, with no change in API. |
… present: treat the rectangular ROI as an ‘and’ combination of two range ROIs instead of a collection of many individual MultiRangeSubsetState ROIs
…lar ROIs to categorical data. Prior to this, we were accidentally looping over all actual data points instead of all categories.
… by setting up dedicated subsetstate classes as opposed to chaining many individual subset states (which would crash above a low number of subset states due to recursion issues)
astrofrog
force-pushed
the
performance-selection
branch
from
a421e6d
to
69e11ab
Compare
astrofrog
added a commit
that referenced
this pull request
Jul 6, 2016
Performance improvements for selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, but I'm going to collect several performance improvements for selections.