Fix to Ginga plugin for colorbar/readout changes #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ejeschke - thanks! I think it would be fine to remove the bits for old versions of ginga. I also think it would still make sense to extract the ginga plugin into a separate package so that we can make releases faster when either glue or ginga change API (as you mentioned in ejeschke/ginga#231). Let's merge this in first and I can then pull this out into a third-party package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@astrofrog, this is a fix for this issue.
I think it might be reasonable to update the plugin to remove some of the bits for old (>1 year) versions of ginga. If you agree I can submit another PR with those changes.
BTW, is there a way to know which version of Qt glue is using (4, 5 or pyside?)