Data loader error now tells you which file is in error #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is probably fine - a better way would be to raise a custom exception in load_data that includes the filename, but at the end of the day this works, and practicality beats purity |
|
For some reason, "TestImageWidget.test_resize" failed. Why would this extra message affect resizing? Hmm. |
|
That's a test that fails occasionally too - frustrating but can be ignored... |
I agree but sometimes my OCD disagrees. If you change your mind and want the exception raised somewhere else as you stated, just let me know. |
|
Let's just go with this for now :) Thanks @pllim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass in offending filename into loader error message. Fixes #1096.
@astrofrog , is the fix too "hacky"? It does do what I want though.