Implement InequalitySubsetState for categorical components #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this as a bug since this is likely how people intended things to work with the current implementation. |
astrofrog
force-pushed
the
id-equality
branch
2 times, most recently
from
258bf7a
to
c713d7b
Compare
astrofrog
force-pushed
the
id-equality
branch
from
0824e85
to
27c1209
Compare
… components using e.g. d.id['a'] == 'string'
astrofrog
force-pushed
the
id-equality
branch
from
3a7c43a
to
e88f7ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to create InequalitySubsetStates for categorical components using e.g.
d.id['a'] == 'string'