Significant performance improvements for WCS linking with cubes #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
peformance-wcs-linking
branch
from
5ec01a9 to
cd9c083
Compare
…ount dependent coordinates to figure out the minimal amount of coordinates to transform, and broadcast to full size.
…est array possible to represent a previously broadcasted array.
…inate back - this allows optimizations based on the dependent coordinates.
…est a minimum number of times.
… it automatically works for all sub-classes
astrofrog
force-pushed
the
peformance-wcs-linking
branch
from
19a73be to
946bd63
Compare
astrofrog
force-pushed
the
peformance-wcs-linking
branch
from
3b48272 to
d3b74e5
Compare
|
Travis is passing except for the Mac builds, which are delayed, but they were passing before, so I think it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a number of general performance improvements mainly related to avoiding repeating calculations in broadcasted arrays. The most immediate application is when linking e.g. a spectral cube and an image, selections in the image now propagate very fast to cubes.