Properly deal with reassignment of Data.coords #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
coords-reassignment
branch
2 times, most recently
from
2d34c11 to
a0f352f
Compare
astrofrog
force-pushed
the
coords-reassignment
branch
from
a0f352f to
90f2d6c
Compare
|
Still need to add a test to make sure all links based on the old world coordinates are removed |
astrofrog
force-pushed
the
coords-reassignment
branch
from
c8ccaac to
0b46f7b
Compare
astrofrog
added a commit
that referenced
this pull request
May 8, 2018
Properly deal with reassignment of Data.coords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-compute world components if
Data.coordsis changed.This will need to be rebased after #1195 is merged and also will have some failures we need to investigate after #1189 is merged.