Fix how we deal with component IDs for linked components #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when linking two components, we added the component ID of the linked component in each dataset to the other dataset, and set .hidden to True. However since the component ID was shared, this also hid the component ID in the original data. Instead, we now don't hide the component IDs, but instead treat component IDs where .parent is not the dataset being looked at to be effectively hidden.
astrofrog
changed the title
astrofrog
added a commit
that referenced
this pull request
Apr 19, 2017
Fix how we deal with component IDs for linked components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when linking two components, we added the component ID of the linked component in each dataset to the other dataset, and set .hidden to True. However since the component ID was shared, this also hid the component ID in the original data. Instead, we now don't hide the component IDs, but instead treat component IDs where .parent is not the dataset being looked at to be effectively hidden.
Fixes #1257