Made file extension check case insensitive. #1275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I was playing around with glue today, and noticed that it would not load some of my .PNG files. I realized this was because glue technically only accepts ".png" files, not ".PNG" files. This probably isn't a problem for most PNG files out there, but I think Windows (my laptop) randomly prefers to save into ".PNG" format by default, which can be a pain for using glue. This problem might be a little confusing on Windows too, as Windows is case insensitive (unlike Linux) for file extensions.
To fix it, I just made the extension checker function in Glue convert both sides of the equality to lowercase. That way, ".PNG" and any other capital extension would be converted to ".png" before it was checked against a valid list of extensions. As far as I know, this shouldn't break anything else unless there are filetypes out there that are different depending on their casing...
Another option would just to be to add more acceptable extensions on a case by case basis, e.g. ['png', 'PNG', 'jpg', 'JPG', ...] but this seems easier.
The error that pops up when trying to open a ".PNG" file is pasted below:
Some quick test code to test the difference is pasted below: