Implement a new way to deal with combo boxes #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
refactor-combo-handling
branch
from
39957fc
to
554a307
Compare
astrofrog
force-pushed
the
refactor-combo-handling
branch
2 times, most recently
from
009e0fd
to
b4323ae
Compare
…fined as part of the State, not in the Qt code
…at carries the choices inside it
astrofrog
force-pushed
the
refactor-combo-handling
branch
from
b4323ae
to
d254e1e
Compare
astrofrog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The choices are defined in the State, not in the Qt code, moving a reasonable fraction of code to non-Qt-specific code. Just a WIP for now while exploring this.
Things that are missing:
Fixes #1345