Fix spectrum and PV slicer tools and improve overall UI #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregate slice functionality
…iewer when changing aspect ratio
When resetting a session, sys.stderr was already set to GlueLogger and we then did self.stderr = sys.stderr and sys.stderr = self so we ended up with two references to GlueLogger. This caused issues because the original logger would try and write to the button that was in the first (now deleted) application.
… opening a session, otherwise the terminal doesn't get set up.
…e confusion when pressing shift e.g. to capitalize a letter in the terminal
… restored if an exception happened during drawing.
…ly removing the layer (unlike the clear method)
astrofrog
force-pushed
the
fix-spectrum-pv
branch
from
dbace9f
to
da21368
Compare
|
The failures are now unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also internally (for now) allows aggregation in the image viewer (used by the spectrum tool). Will need to expose that in future as an alternative to slicing.
Also fixes issues with the GlueLogger and Ipython terminal when resetting or opening sessions from glue.
Finally improves the overall UI, moving buttons to the toolbar and making it clearer what they do.