Various fixes, including disabling layers properly in UI #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill allow the layer list to refresh
…o e.g. incompatible attributes
…bled or disabled layers is called.
…r, we disable global syncing for those specific layers. Also make use of the improved set_multiple_data behavior to simplify code.
… layer artist, not the global data color (since they are not always in sync)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other improvements include simplifying calls to set_multiple_data to avoid repeated logic, and showing colormaps in the icons in the layer artists. This also makes sure that we disable syncing of layers if they correspond to a common dataset.