Refactor link handling #1533
Merged
Refactor link handling #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s any derived component that depends on it.
…ataset removes any links that depend on that component
…onents that can no longer be derived. Also make it so that Data can contain 'externally derived components' that are separate from the main components - this container can then be used to store derived components from links.
…ernal to the dataset
Data objects are now responsible for storing internal derived component links and coordinate links, and the LinkManager fetches those links on-the-fly, removing the need to sync.
…o the LinkManager
astrofrog
force-pushed
the
refactor-data-links
branch
from
d1dc5bc
to
70c83ef
Compare
astrofrog
force-pushed
the
refactor-data-links
branch
from
70c83ef
to
76393b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started off as a small bug fix for #1532, but I've now refactored how links and derived components from links are stored internally. More explanations soon...
Things that still need doing:
Things we can do in a future PR: