Fix calculation of dependent axes when CD/PC matrix has non-diagonal elements #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e some non-zero non-diagonal PC values. Previously any such values resulted in all axes being returned as dependent axes even though this isn't necessary.
astrofrog
force-pushed
the
fix-dependent-axes
branch
from
a3d0615 to
aa15c31
Compare
astrofrog
added a commit
that referenced
this pull request
Mar 7, 2018
Fix calculation of dependent axes when CD/PC matrix has non-diagonal elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Cadair - this should fix the linking issue you were seeing