Improve performance of slicing #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
slicing-performance
branch
from
c58ebb0
to
6a46afb
Compare
… caused performance issues when slicing through cubes.
astrofrog
force-pushed
the
slicing-performance
branch
from
6a46afb
to
1dd3dd9
Compare
|
Actually I found another bottleneck so things are already a lot faster with multiple subsets. I need to add a regression test. |
astrofrog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this PR doesn't do much but I plan to investigate whether we can use
redraw_frameto avoid calling WCSAxes every time a slice is changed.