Fix bug that caused pressing delete key to mess up viewers #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.close otherwise the MDI widget can get closed before the warning dialog.
… if the image viewer closing was cancelled
astrofrog
added a commit
that referenced
this pull request
Mar 8, 2018
Fix bug that caused pressing delete key to mess up viewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two separate issues here:
Pressing delete causes the viewer to be closed, but the warning about closing comes after the MDI container has already been closed, causing chaos.
Pressing delete activates the Matplotlib 'back' tool even though it is hidden.