Use memory-mapping with HDF5 files whenever possible #1628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work. I tested it out with @maartenbreddels's
sdss_dereddened.hdf5
file and the scatter density plots worked ok. They were slightly sluggish but not dramatically.@maartenbreddels - when you get a chance, can you review this? Thanks for the example implementation!
Open questions:
Should we only do memory mapping for arrays over a certain size, performance-wise?
Does this benefit from any disk I/O caching or does every array access result in an I/O operation?
I also noticed that the auto-merging isn't quite right at the moment, so I'll try and work on that soon, maybe in a separate PR.