Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spectrum tool #1635

Merged
merged 42 commits into from
Apr 3, 2018
Merged

Refactor spectrum tool #1635

merged 42 commits into from
Apr 3, 2018

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Mar 29, 2018 •
edited
Loading

This is a work in progress, but the aim is to add a profile viewer which is a proper data viewer and to use this instead of the current spectrum tool.

Things that still need to be done:

  • Add a way to have a vertical line that connects to a slice in an image viewer
  • Add a way to create moment maps based on an interval in the profile
  • Add a way to do interactive fitting
  • Add proper test suite
  • Add changelog entry/what's new entry
  • Show world coordinates on axis
  • Add a 'reference data' combo to avoid confusion
  • Don't show missing values in profile as zero
  • Don't enable navigation tool without sidebar present
  • Added tests for data linking/world coordinates

@astrofrog astrofrog added this to the v0.13.0 milestone Mar 31, 2018
@astrofrog
Added implementation for a simple profile viewer with the aim to repl…
acca630 
…ace the spectrum tool
@astrofrog
Started implementing a navigation mouse mode
64a02a0
@astrofrog
Implemented RangeMouseMode
f3ad776
@astrofrog
Started implementing profile tools side panel
88498f2
@astrofrog
Implemented fitting panel
5f78f87
@astrofrog
Make the profile tools able to add themselves to the ProfileViewer
b48e171
@astrofrog
Implementing collapsing
ccf719a
@astrofrog
Minor esthetic improvements
f8fa1c9
@astrofrog
More fixes/improvements
11556ba
@astrofrog
Added changelog entry
0e7c662
@astrofrog
Avoid circular references
51d51e6
@astrofrog
Added a new tool to start the profile viewer from the image viewer
0f7f330
@astrofrog
Moved Qt fitter-related tests
0d2bd2a
@astrofrog
Remove old spectrum plugin
3aa3061
@astrofrog
Remove unused imports
3d73d98
@astrofrog
Added tests for the profile states
ea17138
@astrofrog
Small fixes
f5250ad
@astrofrog
Added tests for mouse modes
52410e0
@astrofrog
Added another viewer test
8e13832
@astrofrog
Added a test when incompatible data is present
a73191b
@astrofrog
Started added tests for ProfileTools
62f6849
@astrofrog
Finish adding tests
4390c52
@astrofrog
Make function order deterministic
ae28c03
@astrofrog
Added a new function 'is_convertible_to_single_pixel_cid' which will …
237834b 
…help us determine whether a profile can be plotted for a given dataset
@astrofrog
Make it possible to overlay datasets with linked pixel coordinates
eccdcac
@astrofrog
Show world coordinates in combo box
72e455d
@astrofrog
Show warning when profile viewer is empty
185f2dc
@astrofrog
Added reference_data combo
32ed0b1
@astrofrog
Hide missing profile values instead of using zero
ea2644d
@astrofrog
Make StateAttributeLimitsHelper adjust return values by 0.5 when cons…
1a7feab 
…idering pixel components
@astrofrog
Only enable slice navigator when profile tools are shown
754353c
@astrofrog
Fix tests
78f3ad7
@astrofrog
Started adding tests and fixing issues for world coordinates
e4d5d29
@astrofrog
Finish fixing profile tools when used with world axes
cd415ab
@astrofrog
Added test of selection and enabled layers
e0e53f0
@astrofrog
Avoid rounding issues
1608b3c
@astrofrog
Fixed test and removed unused code
a6830b0
@astrofrog
Make sure data components are floating-point in tests
39f990e
@astrofrog
Move mouse_mode code inside qt subfolder
88d7877
@astrofrog
Fix compatibility with Matplotlib 1.5
450e5cf
@astrofrog
Fix failures on Windows
0d9ff66
@astrofrog
Use deterministic order for functions
be5f3cb
@astrofrog
Copy link
Member Author

I'll fix the failing Travis job (Matplotlib 1.5) in a follow-up PR that will make other improvements too

@astrofrog astrofrog merged commit 3fd167a into glue-viz:master Apr 3, 2018
This was referenced Apr 4, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement merge-when-ci-passes plugin-spectrum-tool whats-new-needed
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
1 participant
@astrofrog