Make it possible to have a 'None' entry in ComponentIDComboHelper #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think "No Display" or something like that ? "None" might confuse pythonic types of people. Empty might make it difficult for understanding too. |
astrofrog
force-pushed
the
cid-helper-none
branch
from
f40651f
to
4db0662
Compare
|
@brechmos-stsci - in the end I made it so that you can customize what you want shown for the None entry by simply setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509
@brechmos-stsci - do you have any thoughts on what the 'None' entry should show up as in the combo - should it be an empty string, or should it actually say 'None'?