Refactor how categorical data is dealt with #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…darray class that deals with the computation of codes and labels
…de - for instance checking if a component is categorical can be done via Data.get_kind(cid) instead of Data.get_component(cid).categorical.
…ld_component_ids and get_pixel_component_ids since they duplicate the equivalent properties.
…mon to all datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new categorical data ndarray class that deals with the calculation of labels, categories, and codes. This will then allow custom Data sub-classes to return this without having to use CategoricalComponent.
Things to do: