Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom layer maker registry #1850

Merged
merged 15 commits into from
Nov 13, 2018

Conversation

keflavich
Copy link
Contributor

cc @astrofrog, @catherinezucker - this is infrastructure required for the region plugin.

WIP - do not merge!

@astrofrog
Copy link
Member

@keflavich @catherinezucker - I'm going to be cutting a 0.14 release early next week. Are you interested in finishing this PR up by then, or will we just keep this for the next release?

@keflavich
Copy link
Contributor Author

I don't have time to work on it; what more is needed though? Do we need some sort of tests for this?

@astrofrog
Copy link
Member

@keflavich - I'm happy to finish it up and add a few tests. Could you rebase first though, as I think it will fix the CI?

@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #1850 into master will increase coverage by 0.04%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1850      +/-   ##
==========================================
+ Coverage   85.51%   85.56%   +0.04%     
==========================================
  Files         235      235              
  Lines       20899    20949      +50     
==========================================
+ Hits        17871    17924      +53     
+ Misses       3028     3025       -3
Impacted Files Coverage Δ
glue/core/application_base.py 83.87% <ø> (-0.09%) ⬇️
glue/app/qt/application.py 78% <100%> (+0.1%) ⬆️
glue/core/layer_artist.py 78.88% <60%> (+0.89%) ⬆️
glue/config.py 81.79% <84.61%> (+0.1%) ⬆️
glue/viewers/common/viewer.py 92.2% <93.33%> (+2.16%) ⬆️
glue/core/subset.py 88.03% <95.45%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 330d68b...52247be. Read the comment docs.

@astrofrog
Copy link
Member

@keflavich @catherinezucker - I've finally had a chance to finish this up and add tests and docs. Note that I've changed how the custom layer artist stuff works a little to make it more general. Basically you need to write a function that takes a viewer and data or subset object, and returns either a layer artist or None. So for the regions plugin, you'll need to adjust this. See the docs in this PR.

@astrofrog astrofrog added this to the v0.14.0 milestone Nov 9, 2018
@astrofrog astrofrog merged commit df3925c into glue-viz:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants