-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom layer maker registry #1850
Conversation
@keflavich @catherinezucker - I'm going to be cutting a 0.14 release early next week. Are you interested in finishing this PR up by then, or will we just keep this for the next release? |
I don't have time to work on it; what more is needed though? Do we need some sort of tests for this? |
@keflavich - I'm happy to finish it up and add a few tests. Could you rebase first though, as I think it will fix the CI? |
e771e2a
to
3180883
Compare
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
+ Coverage 85.51% 85.56% +0.04%
==========================================
Files 235 235
Lines 20899 20949 +50
==========================================
+ Hits 17871 17924 +53
+ Misses 3028 3025 -3
Continue to review full report at Codecov.
|
1a1a52d
to
fa490dd
Compare
…o implementation is fine in some cases)
fa490dd
to
af77ae8
Compare
@keflavich @catherinezucker - I've finally had a chance to finish this up and add tests and docs. Note that I've changed how the custom layer artist stuff works a little to make it more general. Basically you need to write a function that takes a viewer and data or subset object, and returns either a layer artist or |
cc @astrofrog, @catherinezucker - this is infrastructure required for the region plugin.
WIP - do not merge!