Fixed a bug due to Numpy not being imported under certain circumstances #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
=========================================
+ Coverage 85.5% 85.5% +<.01%
=========================================
Files 235 235
Lines 20877 20878 +1
=========================================
+ Hits 17851 17852 +1
Misses 3026 3026
Continue to review full report at Codecov.
|
astrofrog
force-pushed
the
fix-undefined-np
branch
from
127bfc0 to
43a4697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened if Numpy was imported (as np) in
config.py(which is a completely valid thing to do)