Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unecessary warnings #1890

Merged
merged 3 commits into from
Nov 1, 2018

Conversation

astrofrog
Copy link
Member

Avoid warning when closing empty tab, and avoid additional warnings when closing a tab with open viewers.

@astrofrog astrofrog added this to the v0.14.0 milestone Oct 30, 2018
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #1890 into master will decrease coverage by <.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1890      +/-   ##
=========================================
- Coverage   85.51%   85.5%   -0.01%     
=========================================
  Files         235     235              
  Lines       20892   20896       +4     
=========================================
+ Hits        17865   17868       +3     
- Misses       3027    3028       +1
Impacted Files Coverage Δ
glue/viewers/common/qt/base_widget.py 73.38% <100%> (-0.22%) ⬇️
glue/app/qt/application.py 77.89% <50%> (+0.02%) ⬆️
glue/viewers/common/state.py 84.21% <0%> (-15.79%) ⬇️
glue/core/data_factories/fits.py 89.06% <0%> (+0.78%) ⬆️
glue/utils/qt/helpers.py 55.55% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0594942...de46b79. Read the comment docs.

@astrofrog astrofrog merged commit 162b6cc into glue-viz:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant