-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how we handle reprojection #1895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
improved-reproject
branch
2 times, most recently
from
December 2, 2018 06:14
f4b289d
to
039d0bc
Compare
…lement general Data.get_fixed_resolution_buffer method
…prove performance of CoordinateComponentLink.using
…ing in meshgrid, and unbroadcasting temporarily when converting coordinates to integers
…che for image viewer, and make sure we re-use cache if irrelevant bounds change
…ers got enabled/disabled
…ist class for the image viewer
astrofrog
force-pushed
the
improved-reproject
branch
from
January 25, 2019 11:58
e448709
to
e00543d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
==========================================
+ Coverage 85.58% 85.63% +0.04%
==========================================
Files 236 238 +2
Lines 21066 21227 +161
==========================================
+ Hits 18030 18177 +147
- Misses 3036 3050 +14
Continue to review full report at Codecov.
|
astrofrog
force-pushed
the
improved-reproject
branch
from
January 27, 2019 20:20
bc21b99
to
bef69ce
Compare
astrofrog
force-pushed
the
improved-reproject
branch
from
January 27, 2019 20:57
bef69ce
to
0147af3
Compare
Closed
…with a get_array method
astrofrog
force-pushed
the
improved-reproject
branch
from
January 28, 2019 15:50
3779297
to
6cb2dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when reprojecting an image to another image, we are limiting the footprint of the final image to the original one we are reprojecting to, but this isn't right - we should reproject to all available pixels in the image viewer axes.
Remaining to-dos:
get_fixed_resolution_buffer
since it is an optimization that would be useful for all callers.get_array
methodAddress in future pull requests:
get_fixed_resolution_buffer
method can be optimized, or needs optimizing