Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how we handle reprojection #1895

Merged
merged 32 commits into from
Jan 28, 2019

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Nov 8, 2018

Currently, when reprojecting an image to another image, we are limiting the footprint of the final image to the original one we are reprojecting to, but this isn't right - we should reproject to all available pixels in the image viewer axes.

Remaining to-dos:

  • Add back some kind of caching infrastructure, but in get_fixed_resolution_buffer since it is an optimization that would be useful for all callers.
  • Fix tests marked as xfail
  • Release new version of mpl-scatter-density and up minimum requirement
  • Make Python export work for reprojection
  • Deal with aggregation
  • Test out with 3D viewers to see if it will be appropriate
  • Make array maker be callable rather than have a get_array method
  • Check Python export with transposed data

Address in future pull requests:

  • See if the base get_fixed_resolution_buffer method can be optimized, or needs optimizing

@astrofrog astrofrog added this to the v0.15.0 milestone Nov 9, 2018
@astrofrog astrofrog force-pushed the improved-reproject branch 2 times, most recently from f4b289d to 039d0bc Compare December 2, 2018 06:14
@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #1895 into master will increase coverage by 0.04%.
The diff coverage is 96.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
+ Coverage   85.58%   85.63%   +0.04%     
==========================================
  Files         236      238       +2     
  Lines       21066    21227     +161     
==========================================
+ Hits        18030    18177     +147     
- Misses       3036     3050      +14
Impacted Files Coverage Δ
glue/_deps.py 63.8% <ø> (ø) ⬆️
glue/viewers/image/composite_array.py 93.54% <100%> (-1.25%) ⬇️
glue/core/component.py 96.02% <100%> (+0.59%) ⬆️
glue/core/data.py 89.26% <100%> (+0.06%) ⬆️
glue/viewers/image/python_export.py 91.42% <100%> (+3.92%) ⬆️
glue/core/component_link.py 85.34% <100%> (ø) ⬆️
glue/viewers/image/viewer.py 89.86% <100%> (ø) ⬆️
glue/viewers/image/layer_artist.py 90.69% <100%> (-3.62%) ⬇️
glue/viewers/scatter/python_export.py 97.16% <100%> (+0.02%) ⬆️
glue/core/fixed_resolution_buffer.py 95.09% <95.09%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e2088...0f7ab55. Read the comment docs.

@astrofrog astrofrog mentioned this pull request Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant