-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the log state to the histogram machinery #1963
Conversation
Using the same dataset as #1962 I know have the following plot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just a small comment below, and otherwise can you add an entry under 0.14.3 in CHANGES.md
?
xmin = np.log10(xmin) | ||
xmax = np.log10(xmax) | ||
xmin = np.log10(xmin) if xmin > 0 else np.log10(xmax) - 10 | ||
xmax = np.log10(xmax) if xmax > 0 else np.log10(xmin) + 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might give strange results if both xmin and xmax are zero for some reason - I think it might be best to actually just return an array of NaN values if either xmin or xmax are negative rather than modify the limits. You can construct this array efficiently with:
broadcast_to(np.nan, bins)
could you update this here and below?
Codecov Report
@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
+ Coverage 87.48% 87.54% +0.05%
==========================================
Files 244 244
Lines 21716 21775 +59
==========================================
+ Hits 18999 19062 +63
+ Misses 2717 2713 -4
Continue to review full report at Codecov.
|
I'll go ahead and merge this, thanks @cphyc! |
This fixes #1962.