Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in image viewer when using update_values_from_data #1975

Merged
merged 4 commits into from
Apr 1, 2019

Conversation

astrofrog
Copy link
Member

Fixes #1854

@astrofrog astrofrog added the bug label Mar 31, 2019
@astrofrog astrofrog added this to the v0.14.3 milestone Mar 31, 2019
@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #1975 into master will increase coverage by 0.13%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1975      +/-   ##
=========================================
+ Coverage   87.47%   87.6%   +0.13%     
=========================================
  Files         244     244              
  Lines       21746   21857     +111     
=========================================
+ Hits        19022   19148     +126     
+ Misses       2724    2709      -15
Impacted Files Coverage Δ
glue/core/data.py 90.37% <100%> (+0.09%) ⬆️
glue/viewers/image/state.py 90.09% <91.42%> (-0.04%) ⬇️
glue/viewers/table/qt/data_viewer.py 96.95% <0%> (+0.09%) ⬆️
glue/viewers/common/qt/data_viewer.py 98.74% <0%> (+1.61%) ⬆️
glue/main.py 93.92% <0%> (+2.15%) ⬆️
glue/_deps.py 66.25% <0%> (+2.45%) ⬆️
glue/core/layer_artist.py 81.21% <0%> (+3.18%) ⬆️
glue/core/hub.py 85.58% <0%> (+7.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8003611...53980cb. Read the comment docs.

@astrofrog astrofrog merged commit d8889a8 into glue-viz:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant