Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Qt-specific ROI plotting #1983

Merged
merged 6 commits into from
Apr 16, 2019
Merged

Conversation

astrofrog
Copy link
Member

Thanks to improvements in Matplotlib, we can just define efficient selection tools directly in Matplotlib, which then means being able to use them in e.g. glue-jupyter with the Matplotlib viewers there.

…de as efficient (and can then be used with other backends)
@astrofrog astrofrog marked this pull request as ready for review April 16, 2019 11:56
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e5dd5b1). Click here to learn what that means.
The diff coverage is 95.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1983   +/-   ##
=========================================
  Coverage          ?   87.76%           
=========================================
  Files             ?      243           
  Lines             ?    21662           
  Branches          ?        0           
=========================================
  Hits              ?    19012           
  Misses            ?     2650           
  Partials          ?        0
Impacted Files Coverage Δ
glue/viewers/common/qt/toolbar_mode.py 89.84% <100%> (ø)
glue/viewers/image/qt/mouse_mode.py 45.58% <50%> (ø)
glue/core/roi.py 93.77% <96.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5dd5b1...1cee653. Read the comment docs.

@astrofrog astrofrog added this to the v0.15.0 milestone Apr 16, 2019
@astrofrog astrofrog merged commit 1c99842 into glue-viz:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant